Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
tf_mod_aws_vpc
tf_mod_aws_vpc
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • steamhaus
  • tf_mod_aws_vpctf_mod_aws_vpc
  • Merge Requests
  • !1

Open
Opened Jun 22, 2018 by Chris Merrett@chris
  • Report abuse
Report abuse

Add EKS support to VPC module

This MR allows the user to enable EKS support, so that EKS clusters can share a pre-existing VPC in a non-destructive way. Tested within Radio.co's staging environment with success.

For further testing, it'd be useful to attempt a terraform plan against this branch in another account/environment.

Desired effect is extra tags when EKS is enabled, and no change when not enabled.

New variables for this module are enable_eks_support = "true|false" and eks_cluster_name = "string". Both variables are string types.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b chris/add-eks-support origin/chris/add-eks-support

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff chris/add-eks-support

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 0
  • Commits 7
  • Pipelines 7
  • Changes 3
Rob Greenwood
Assignee
Rob Greenwood @rob
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: steamhaus/tf_mod_aws_vpc!1