Commit 3cf85a3c authored by Chris Merrett's avatar Chris Merrett

Fixed syntax of formatlist

parent 2aef5c52
Pipeline #773 passed with stage
in 6 seconds
......@@ -17,7 +17,7 @@ data "aws_iam_policy_document" "main" {
sid = "AWSCloudTrailAclCheck"
effect = "Allow"
actions = ["s3:GetBucketAcl"]
resources = "arn:aws:s3:::${var.customer_name}-${var.environment}-cloudtrail"
resources = ["arn:aws:s3:::${var.customer_name}-${var.environment}-cloudtrail"]
principals {
type = "Service"
......@@ -29,7 +29,7 @@ data "aws_iam_policy_document" "main" {
sid = "AWSCloudTrailWrite"
effect = "Allow"
actions = ["s3:PutObject"]
resources = "arn:aws:s3:::${var.customer_name}-${var.environment}-cloudtrail/*"
resources = ["arn:aws:s3:::${var.customer_name}-${var.environment}-cloudtrail/*"]
principals {
type = "Service"
......@@ -47,7 +47,7 @@ data "aws_iam_policy_document" "main" {
sid = "AWSCloudTrailWrite"
effect = "Allow"
actions = ["s3:PutObject"]
resources = ["${formatlist("arn:aws:s3:::$${var.customer_name}-$${var.environment}-cloudtrail/AWSLogs/%s/*", var.child_accounts)}"]
resources = ["${formatlist("arn:aws:s3:::${var.customer_name}-${var.environment}-cloudtrail/AWSLogs/%s/*", var.child_accounts)}"]
principals {
type = "Service"
......
{
"Version": "2012-10-17",
"Statement": [
{
"Sid": "AWSCloudTrailAclCheck",
"Effect": "Allow",
"Principal": {
"Service": "cloudtrail.amazonaws.com"
},
"Action": "s3:GetBucketAcl",
"Resource": "arn:aws:s3:::${customer_name}-${environment}-cloudtrail"
},
{
"Sid": "AWSCloudTrailWrite",
"Effect": "Allow",
"Principal": {
"Service": "cloudtrail.amazonaws.com"
},
"Action": "s3:PutObject",
"Resource": "arn:aws:s3:::${customer_name}-${environment}-cloudtrail/*",
"Condition": {
"StringEquals": {
"s3:x-amz-acl": "bucket-owner-full-control"
}
}
}
]
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment